netdev - Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJieiUh0c1LCud2ZNuD5MygrBO=Yb1OgqHawxjgkX1j+6NHMrQ@mail.gmail.com>
Date:   Wed, 29 Apr 2020 08:12:14 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Benjamin Poirier <bpoirier@...ulusnetworks.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output

On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier
<bpoirier@...ulusnetworks.com> wrote:
>
> Output the same names for vlan flags as the ones accepted in command input.
>
> Signed-off-by: Benjamin Poirier <bpoirier@...ulusnetworks.com>
> ---

Benjamin, It's a good change,  but this will break existing users ?.


>  bridge/vlan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bridge/vlan.c b/bridge/vlan.c
> index 205851e4..08b19897 100644
> --- a/bridge/vlan.c
> +++ b/bridge/vlan.c
> @@ -398,10 +398,10 @@ static void print_vlan_flags(__u16 flags)
>
>         open_json_array(PRINT_JSON, "flags");
>         if (flags & BRIDGE_VLAN_INFO_PVID)
> -               print_string(PRINT_ANY, NULL, " %s", "PVID");
> +               print_string(PRINT_ANY, NULL, " %s", "pvid");
>
>         if (flags & BRIDGE_VLAN_INFO_UNTAGGED)
> -               print_string(PRINT_ANY, NULL, " %s", "Egress Untagged");
> +               print_string(PRINT_ANY, NULL, " %s", "untagged");
>         close_json_array(PRINT_JSON, NULL);
>  }
>
> --
> 2.26.0
>