netdev - Re: [PATCH net-next] net/smc: remove unused inline function smc_curs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <039d6d59-5dd5-c89a-c174-72f4de3d0098@linux.ibm.com>
Date:   Wed, 29 Apr 2020 17:15:55 +0200
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     YueHaibing <yuehaibing@...wei.com>, ubraun@...ux.ibm.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: remove unused inline function
 smc_curs_read

On 29/04/2020 15:26, YueHaibing wrote:
> commit bac6de7b6370 ("net/smc: eliminate cursor read and write calls")
> left behind this.
> 

Thanks, good catch. Your patch will be part of our next patch submission.

Regards, Karsten


> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/smc/smc_cdc.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h
> index 861dc24c588c..5a19e5e2280e 100644
> --- a/net/smc/smc_cdc.h
> +++ b/net/smc/smc_cdc.h
> @@ -97,23 +97,6 @@ static inline void smc_curs_add(int size, union smc_host_cursor *curs,
>  	}
>  }
>  
> -/* SMC cursors are 8 bytes long and require atomic reading and writing */
> -static inline u64 smc_curs_read(union smc_host_cursor *curs,
> -				struct smc_connection *conn)
> -{
> -#ifndef KERNEL_HAS_ATOMIC64
> -	unsigned long flags;
> -	u64 ret;
> -
> -	spin_lock_irqsave(&conn->acurs_lock, flags);
> -	ret = curs->acurs;
> -	spin_unlock_irqrestore(&conn->acurs_lock, flags);
> -	return ret;
> -#else
> -	return atomic64_read(&curs->acurs);
> -#endif
> -}
> -
>  /* Copy cursor src into tgt */
>  static inline void smc_curs_copy(union smc_host_cursor *tgt,
>  				 union smc_host_cursor *src,
>