netdev - Re: [PATCH net] devlink: fix return value after hitting end in region read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200429154724.GD6581@nanopsycho.orion>
Date:   Wed, 29 Apr 2020 17:47:24 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kernel-team@...com,
        jacob.e.keller@...el.com, parav@...lanox.com
Subject: Re: [PATCH net] devlink: fix return value after hitting end in
 region read

Wed, Apr 29, 2020 at 04:01:58AM CEST, kuba@...nel.org wrote:
>Commit d5b90e99e1d5 ("devlink: report 0 after hitting end in region read")
>fixed region dump, but region read still returns a spurious error:
>
>$ devlink region read netdevsim/netdevsim1/dummy snapshot 0 addr 0 len 128
>0000000000000000 a6 f4 c4 1c 21 35 95 a6 9d 34 c3 5b 87 5b 35 79
>0000000000000010 f3 a0 d7 ee 4f 2f 82 7f c6 dd c4 f6 a5 c3 1b ae
>0000000000000020 a4 fd c8 62 07 59 48 03 70 3b c7 09 86 88 7f 68
>0000000000000030 6f 45 5d 6d 7d 0e 16 38 a9 d0 7a 4b 1e 1e 2e a6
>0000000000000040 e6 1d ae 06 d6 18 00 85 ca 62 e8 7e 11 7e f6 0f
>0000000000000050 79 7e f7 0f f3 94 68 bd e6 40 22 85 b6 be 6f b1
>0000000000000060 af db ef 5e 34 f0 98 4b 62 9a e3 1b 8b 93 fc 17
>devlink answers: Invalid argument
>0000000000000070 61 e8 11 11 66 10 a5 f7 b1 ea 8d 40 60 53 ed 12
>
>This is a minimal fix, I'll follow up with a restructuring
>so we don't have two checks for the same condition.
>
>Fixes: fdd41ec21e15 ("devlink: Return right error code in case of errors for region read")
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>