netdev - Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2fc6935-555f-b881-1ff2-f824bd08d6ae@cumulusnetworks.com>
Date:   Thu, 30 Apr 2020 03:58:51 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Benjamin Poirier <bpoirier@...ulusnetworks.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and
 output

On 4/30/20 3:22 AM, Benjamin Poirier wrote:
> On 2020-04-29 08:12 -0700, Roopa Prabhu wrote:
>> On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier
>> <bpoirier@...ulusnetworks.com> wrote:
>>>
>>> Output the same names for vlan flags as the ones accepted in command input.
>>>
>>> Signed-off-by: Benjamin Poirier <bpoirier@...ulusnetworks.com>
>>> ---
>>
>> Benjamin, It's a good change,  but this will break existing users ?.
> 
> Nikolay voiced the same concern. The current output looks like
> 
> ben@f3:~$ bridge vlan
> port    vlan ids
> br0     None
> tap0     1 PVID Egress Untagged
> 
> tap1     1 PVID Egress Untagged
> 
> docker0  1 PVID Egress Untagged
> 
> ben@f3:~$
> 
> "PVID Egress Untagged" look like 3 flags to me. Anything we can do to
> improve it?
> 

Put a "," after PVID ? :-)
The bigger problem is that "Egress Untagged" is also used as a flag in the json output.
Anyone parsing that and looking at the flags would be broken. In addition
this has been described in many of HowTos and docs over the years.

I'd just drop this change.

Thanks,
  Nik