netdev - Re: [PATCH iproute2 0/7] bridge vlan output fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200429223534.6f72095c@hermes.lan>
Date:   Wed, 29 Apr 2020 22:35:34 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Benjamin Poirier <bpoirier@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 0/7] bridge vlan output fixes

On Tue, 28 Apr 2020 08:50:44 +0900
Benjamin Poirier <bpoirier@...ulusnetworks.com> wrote:

> More fixes for `bridge vlan` and `bridge vlan tunnelshow` normal and JSON
> mode output.
> 
> Most of the changes are cosmetic except for changes to JSON format (flag
> names, no empty lists).
> 
> Benjamin Poirier (7):
>   bridge: Use the same flag names in input and output
>   bridge: Use consistent column names in vlan output
>   bridge: Fix typo
>   bridge: Fix output with empty vlan lists
>   json_print: Return number of characters printed
>   bridge: Align output columns
>   Replace open-coded instances of print_nl()
> 
>  bridge/vlan.c                            | 115 +++++++++++++++--------
>  include/json_print.h                     |  24 +++--
>  lib/json_print.c                         |  95 ++++++++++++-------
>  tc/m_action.c                            |  14 +--
>  tc/m_connmark.c                          |   4 +-
>  tc/m_ctinfo.c                            |   4 +-
>  tc/m_ife.c                               |   4 +-
>  tc/m_mpls.c                              |   2 +-
>  tc/m_nat.c                               |   4 +-
>  tc/m_sample.c                            |   4 +-
>  tc/m_skbedit.c                           |   4 +-
>  tc/m_tunnel_key.c                        |  16 ++--
>  tc/q_taprio.c                            |   8 +-
>  tc/tc_util.c                             |   4 +-
>  testsuite/tests/bridge/vlan/show.t       |  30 ++++++
>  testsuite/tests/bridge/vlan/tunnelshow.t |   2 +-
>  16 files changed, 212 insertions(+), 122 deletions(-)
>  create mode 100755 testsuite/tests/bridge/vlan/show.t
> 

Most of these look fine. Resend after the the first patch discussion
has resolved.