netdev - Re: [PATCH v2 net-next 15/17] net: atlantic: common functions needed for basic A2 init/deinit hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430143037.6e063414@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 30 Apr 2020 14:30:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>
Subject: Re: [PATCH v2 net-next 15/17] net: atlantic: common functions
 needed for basic A2 init/deinit hw_ops

On Thu, 30 Apr 2020 11:04:43 +0300 Igor Russkikh wrote:
> +	if (hw_atl_utils_ver_match(HW_ATL2_FW_VER_1X,
> +				   self->fw_ver_actual) == 0) {
> +		*fw_ops = &aq_a2_fw_ops;
> +	} else {
> +		aq_pr_err("Bad FW version detected: %x, but continue\n",
> +			  self->fw_ver_actual);
> +		*fw_ops = &aq_a2_fw_ops;
> +	}

nit: I assume that setting fw_ops to the same value is intentional here.
     FWIW it seems more readable when dealing with multiple versions of
     things to use switch statements, and the default clause.


Series looks good to me otherwise.