netdev - Re: [PATCH v2 net-next 08/17] net: atlantic: A2 driver-firmware interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430143019.3c3742d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 30 Apr 2020 15:19:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>
Subject: Re: [PATCH v2 net-next 08/17] net: atlantic: A2 driver-firmware
 interface

On Thu, 30 Apr 2020 11:04:36 +0300 Igor Russkikh wrote:
> +	struct __attribute__ ((__packed__)) {

nit: checkpatch should warn that the kernel style prefers __packed

> +		u8 arp_responder:1;
> +		u8 echo_responder:1;
> +		u8 igmp_client:1;
> +		u8 echo_truncate:1;
> +		u8 address_guard:1;
> +		u8 ignore_fragmented:1;
> +		u8 rsvd:2;
> +
> +		u16 echo_max_len;
> +		u8 rsvd2;
> +	} ipv4_offload;