netdev - Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfmpSdchyUZT5S7k07tDzwraiePsgRBvGe=SaaHvvm83bbBhg@mail.gmail.com>
Date:   Mon, 4 May 2020 10:36:11 -0400
From:   Jarod Wilson <jarod@...hat.com>
To:     Maor Gottlieb <maorg@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, jgg@...lanox.com,
        Doug Ledford <dledford@...hat.com>, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, kuba@...nel.org,
        jiri@...lanox.com, dsahern@...nel.org, leonro@...lanox.com,
        saeedm@...lanox.com, linux-rdma@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, alexr@...lanox.com
Subject: Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

On Thu, Apr 30, 2020 at 2:50 PM Maor Gottlieb <maorg@...lanox.com> wrote:
>
> Hi Dave,
>
> This series is a combination of netdev and RDMA, so in order to avoid
> conflicts, we would like to ask you to route this series through
> mlx5-next shared branch. It is based on v5.7-rc2 tag.
>
> ---------------------------------------------------------------------
>
> The following series adds support to get the LAG master xmit slave by
> introducing new .ndo - ndo_get_xmit_slave. Every LAG module can
> implement it and it first implemented in the bond driver.
> This is follow-up to the RFC discussion [1].
>
> The main motivation for doing this is for drivers that offload part
> of the LAG functionality. For example, Mellanox Connect-X hardware
> implements RoCE LAG which selects the TX affinity when the resources
> are created and port is remapped when it goes down.
>
> The first part of this patchset introduces the new .ndo and add the
> support to the bonding module.
>
> The second part adds support to get the RoCE LAG xmit slave by building
> skb of the RoCE packet based on the AH attributes and call to the new
> .ndo.
>
> The third part change the mlx5 driver driver to set the QP's affinity
> port according to the slave which found by the .ndo.

At a glance, I'm not sure why all the "get the xmit slave" functions
are being passed an skb. None of them should be manipulating the skb,
that should all be done in the respective xmit functions after the
slave has been returned.

--
Jarod Wilson
jarod@...hat.com