netdev - Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27196f08-953a-4558-7c95-90fb13976c92@gmail.com>
Date:   Mon, 4 May 2020 08:41:55 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jarod Wilson <jarod@...hat.com>, Maor Gottlieb <maorg@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, jgg@...lanox.com,
        Doug Ledford <dledford@...hat.com>, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, kuba@...nel.org,
        jiri@...lanox.com, dsahern@...nel.org, leonro@...lanox.com,
        saeedm@...lanox.com, linux-rdma@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, alexr@...lanox.com
Subject: Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

On 5/4/20 8:36 AM, Jarod Wilson wrote:
> At a glance, I'm not sure why all the "get the xmit slave" functions
> are being passed an skb. None of them should be manipulating the skb,
> that should all be done in the respective xmit functions after the
> slave has been returned.

a number of them select a slave based on hash of the packet data -- from
ethernet data only to L3+L4 hashing.