lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 May 2020 16:59:43 -0700 From: Luiz Augusto von Dentz <luiz.dentz@...il.com> To: Marcel Holtmann <marcel@...tmann.org> Cc: Manish Mandlik <mmandlik@...gle.com>, linux-bluetooth <linux-bluetooth@...r.kernel.org>, ChromeOS Bluetooth Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>, Alain Michaud <alainm@...omium.org>, "David S. Miller" <davem@...emloft.net>, Johan Hedberg <johan.hedberg@...il.com>, netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [PATCH] Bluetooth: Terminate the link if pairing is cancelled Hi Manish, Marcel, On Tue, Apr 28, 2020 at 2:38 AM Marcel Holtmann <marcel@...tmann.org> wrote: > > Hi Manish, > > > If user decides to cancel ongoing pairing process (e.g. by clicking > > the cancel button on the pairing/passkey window), abort any ongoing > > pairing and then terminate the link. > > > > Signed-off-by: Manish Mandlik <mmandlik@...gle.com> > > --- > > Hello Linux-Bluetooth, > > > > This patch aborts any ongoing pairing and then terminates the link > > by calling hci_abort_conn() in cancel_pair_device() function. > > > > However, I'm not very sure if hci_abort_conn() should be called here > > in cancel_pair_device() or in smp for example to terminate the link > > after it had sent the pairing failed PDU. > > Id recommend leaving the hci_abort_conn out since that is a policy decision the userspace should be in charge to decide if the link should be disconnected or not. > > Please share your thoughts on this. > > I am look into this. Just bare with me for a bit to verify the call chain. > > Regards > > Marcel > -- Luiz Augusto von Dentz
Powered by blists - more mailing lists