lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 6 May 2020 13:09:27 +0200
From:   Marcel Holtmann <>
To:     Luiz Augusto von Dentz <>
Cc:     Manish Mandlik <>,
        linux-bluetooth <>,
        ChromeOS Bluetooth Upstreaming 
        Alain Michaud <>,
        "David S. Miller" <>,
        Johan Hedberg <>,
        netdev <>,
        LKML <>,
        Jakub Kicinski <>
Subject: Re: [PATCH] Bluetooth: Terminate the link if pairing is cancelled

Hi Luiz,

>>> If user decides to cancel ongoing pairing process (e.g. by clicking
>>> the cancel button on the pairing/passkey window), abort any ongoing
>>> pairing and then terminate the link.
>>> Signed-off-by: Manish Mandlik <>
>>> ---
>>> Hello Linux-Bluetooth,
>>> This patch aborts any ongoing pairing and then terminates the link
>>> by calling hci_abort_conn() in cancel_pair_device() function.
>>> However, I'm not very sure if hci_abort_conn() should be called here
>>> in cancel_pair_device() or in smp for example to terminate the link
>>> after it had sent the pairing failed PDU.
> Id recommend leaving the hci_abort_conn out since that is a policy
> decision the userspace should be in charge to decide if the link
> should be disconnected or not.

eventually the link will disconnect anyway if we have no users. However maybe we should try to track if we created the link because Pair Device action. If created the link, then aborting the pairing should disconnect the link right away. Otherwise we can leave it around.



Powered by blists - more mailing lists