netdev - Re: [PATCH net] selftests: net: tcp_mmap: clear whole tcp_zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvZWWFnTHV7KCQOekh_265_vKGk=3+P4qbwY+EpwHO2QyQ@mail.gmail.com>
Date:   Wed, 6 May 2020 09:38:51 -0400
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Arjun Roy <arjunroy@...gle.com>
Subject: Re: [PATCH net] selftests: net: tcp_mmap: clear whole
 tcp_zerocopy_receive struct

On Tue, May 5, 2020 at 11:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> We added fields in tcp_zerocopy_receive structure,
> so make sure to clear all fields to not pass garbage to the kernel.
>
> We were lucky because recent additions added 'out' parameters,
> still we need to clean our reference implementation, before folks
> copy/paste it.
>
> Fixes: c8856c051454 ("tcp-zerocopy: Return inq along with tcp receive zerocopy.")
> Fixes: 33946518d493 ("tcp-zerocopy: Return sk_err (if set) along with tcp receive zerocopy.")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Arjun Roy <arjunroy@...gle.com>
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Thank you for fixing the self test!

> ---
>  tools/testing/selftests/net/tcp_mmap.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c
> index 35505b31e5cc092453ea7b72d9dba45bed2d6549..62171fd638c817dabe2d988f3cfae74522112584 100644
> --- a/tools/testing/selftests/net/tcp_mmap.c
> +++ b/tools/testing/selftests/net/tcp_mmap.c
> @@ -165,9 +165,10 @@ void *child_thread(void *arg)
>                         socklen_t zc_len = sizeof(zc);
>                         int res;
>
> +                       memset(&zc, 0, sizeof(zc));
>                         zc.address = (__u64)((unsigned long)addr);
>                         zc.length = chunk_size;
> -                       zc.recv_skip_hint = 0;
> +
>                         res = getsockopt(fd, IPPROTO_TCP, TCP_ZEROCOPY_RECEIVE,
>                                          &zc, &zc_len);
>                         if (res == -1)
> --
> 2.26.2.526.g744177e7f7-goog
>