netdev - Re: [PATCH net] selftests: net: tcp_mmap: clear whole tcp_zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 May 2020 13:47:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        arjunroy@...gle.com, soheil@...gle.com
Subject: Re: [PATCH net] selftests: net: tcp_mmap: clear whole
 tcp_zerocopy_receive struct

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue,  5 May 2020 20:51:06 -0700

> We added fields in tcp_zerocopy_receive structure,
> so make sure to clear all fields to not pass garbage to the kernel.
> 
> We were lucky because recent additions added 'out' parameters,
> still we need to clean our reference implementation, before folks
> copy/paste it.
> 
> Fixes: c8856c051454 ("tcp-zerocopy: Return inq along with tcp receive zerocopy.")
> Fixes: 33946518d493 ("tcp-zerocopy: Return sk_err (if set) along with tcp receive zerocopy.")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Arjun Roy <arjunroy@...gle.com>
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>

Applied, thanks Eric.