lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 06 May 2020 13:49:40 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

From: Manivannan Sadhasivam <>
Date: Wed,  6 May 2020 10:20:14 +0530

> +/* From QRTR to MHI */
> +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev,
> +				      struct mhi_result *mhi_res)
> +{
> +	struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr;

You never need to cast to another pointer type from "void *", that's
the whole point of a void pointer.

So please remove this "struct sk_buff *" cast, thank you.

Please audit your entire submission for this problem.

Powered by blists - more mailing lists