netdev - Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c820a16-9c5f-1536-c4ea-6cd7658178c1@ti.com>
Date:   Wed, 6 May 2020 16:49:59 -0400
From:   Murali Karicheri <m-karicheri2@...com>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol
 variable

Hi Vinicius,

On 5/6/20 1:33 PM, Vinicius Costa Gomes wrote:
> Hi Murali,
> 
> Murali Karicheri <m-karicheri2@...com> writes:
> 
>> Fix following sparse checker warning:-
>>
>> net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types)
>> net/hsr/hsr_slave.c:38:18:    expected unsigned short [unsigned] [usertype] protocol
>> net/hsr/hsr_slave.c:38:18:    got restricted __be16 [usertype] h_proto
>> net/hsr/hsr_slave.c:39:25: warning: restricted __be16 degrades to integer
>> net/hsr/hsr_slave.c:39:57: warning: restricted __be16 degrades to integer
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
>> ---
> 
> I think this patch should go via the net tree, as it is a warning fix.
> Anyway...
> 
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> 
> 
Thanks. I will re-send it with net prefix and you ack. I thought since
this is just a warning, it is not that serious to include in net tree.

-- 
Murali Karicheri
Texas Instruments