lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 May 2020 15:43:51 +0800 From: Jason Yan <yanaijie@...wei.com> To: <arend.vanspriel@...adcom.com>, <franky.lin@...adcom.com>, <hante.meuleman@...adcom.com>, <chi-hsien.lin@...ress.com>, <wright.feng@...ress.com>, <kvalo@...eaurora.org>, <davem@...emloft.net>, <linux-wireless@...r.kernel.org>, <brcm80211-dev-list.pdl@...adcom.com>, <brcm80211-dev-list@...ress.com>, <netdev@...r.kernel.org> CC: Jason Yan <yanaijie@...wei.com> Subject: [PATCH v2] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame() Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8: WARNING: Comparison to bool Signed-off-by: Jason Yan <yanaijie@...wei.com> Reviewed-by: Chi-hsien Lin <chi-hsien.lin@...ress.com> --- v2: Rebased on top of wireless-drivers-next and drop one already fixed line. drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index e32c24a2670d..8cde31675dfb 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -1836,7 +1836,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg, dwell_overflow = brcmf_p2p_check_dwell_overflow(requested_dwell, dwell_jiffies); } - if (ack == false) { + if (!ack) { bphy_err(drvr, "Failed to send Action Frame(retry %d)\n", tx_retry); clear_bit(BRCMF_P2P_STATUS_GO_NEG_PHASE, &p2p->status); -- 2.21.1
Powered by blists - more mailing lists