netdev - Re: [PATCH net-next 06/12] net: qed: gather debug data on hw errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01a9d7a5-3f8c-1799-cd0e-bb2dc8c7f177@marvell.com>
Date:   Fri, 8 May 2020 11:00:21 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Ariel Elior" <aelior@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Denis Bolotin" <dbolotin@...vell.com>
Subject: Re: [PATCH net-next 06/12] net: qed: gather debug data on hw errors


> On Wed, 6 May 2020 14:33:08 +0300 Igor Russkikh wrote:
>> To implement debug dump retrieval on a live system we add callbacks to
>> collect the same data which is collected now during manual `ethtool -d`
>> call.
>>
>> But we instead collect the dump immediately at the moment bad thing
>> happens, and save it for later retrieval by the same `ethtool -d`.
>>
>> To have ability to track this event, we add kobject uevent trigger,
>> so udev event handler script could be used to automatically collect
> dumps.
> 
> No way. Please use devlink health. Instead of magic ethtool dumps and
> custom udev.
> 

Hi Jakub,

Thanks for the suggestion. I've looked into devlink health infrastructure, but
what's warned me is that our device health dumps are huge (~3Mb). I'm not sure
if health dump infrastructure is designed to push that amounts of data.

I'll check if that's feasible.

Thanks,
  Igor