lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 12 May 2020 05:59:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>,
        devel@...verdev.osuosl.org, linux-wireless@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH 13/17] staging: wfx: fix endianness of the field 'len'

Hi Jerome,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20200511]
[cannot apply to v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jerome-Pouiller/staging-wfx-fix-support-for-big-endian-hosts/20200512-031750
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ae73e7784871ebe2c43da619b4a1e2c9ff81508d
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/byteorder/big_endian.h:5,
                    from arch/m68k/include/uapi/asm/byteorder.h:5,
                    from include/asm-generic/bitops/le.h:6,
                    from arch/m68k/include/asm/bitops.h:528,
                    from include/linux/bitops.h:29,
                    from include/linux/kernel.h:12,
                    from include/asm-generic/bug.h:19,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/gpio/consumer.h:6,
                    from drivers/staging/wfx/bh.c:8:
   drivers/staging/wfx/bh.c: In function 'tx_helper':
>> drivers/staging/wfx/bh.c:202:39: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [-Wint-conversion]
     202 |  cpu_to_le16s(((struct hif_msg *)data)->len);
   include/uapi/linux/byteorder/big_endian.h:96:38: note: in definition of macro '__cpu_to_le16s'
      96 | #define __cpu_to_le16s(x) __swab16s((x))
         |                                      ^
>> drivers/staging/wfx/bh.c:202:2: note: in expansion of macro 'cpu_to_le16s'
     202 |  cpu_to_le16s(((struct hif_msg *)data)->len);
         |  ^~~~~~~~~~~~
   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:13,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/m68k/include/uapi/asm/byteorder.h:5,
                    from include/asm-generic/bitops/le.h:6,
                    from arch/m68k/include/asm/bitops.h:528,
                    from include/linux/bitops.h:29,
                    from include/linux/kernel.h:12,
                    from include/asm-generic/bug.h:19,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/gpio/consumer.h:6,
                    from drivers/staging/wfx/bh.c:8:
   include/uapi/linux/swab.h:240:37: note: expected '__u16 *' {aka 'short unsigned int *'} but argument is of type 'u16' {aka 'short unsigned int'}
     240 | static inline void __swab16s(__u16 *p)
         |                              ~~~~~~~^

vim +/__swab16s +202 drivers/staging/wfx/bh.c

   169	
   170	static void tx_helper(struct wfx_dev *wdev, struct hif_msg *hif)
   171	{
   172		int ret;
   173		void *data;
   174		bool is_encrypted = false;
   175		size_t len = hif->len;
   176	
   177		WARN(len < sizeof(*hif), "try to send corrupted data");
   178	
   179		hif->seqnum = wdev->hif.tx_seqnum;
   180		wdev->hif.tx_seqnum = (wdev->hif.tx_seqnum + 1) % (HIF_COUNTER_MAX + 1);
   181	
   182		if (wfx_is_secure_command(wdev, hif->id)) {
   183			len = round_up(len - sizeof(hif->len), 16) + sizeof(hif->len) +
   184				sizeof(struct hif_sl_msg_hdr) +
   185				sizeof(struct hif_sl_tag);
   186			// AES support encryption in-place. However, mac80211 access to
   187			// 802.11 header after frame was sent (to get MAC addresses).
   188			// So, keep origin buffer clear.
   189			data = kmalloc(len, GFP_KERNEL);
   190			if (!data)
   191				goto end;
   192			is_encrypted = true;
   193			ret = wfx_sl_encode(wdev, hif, data);
   194			if (ret)
   195				goto end;
   196		} else {
   197			data = hif;
   198		}
   199		WARN(len > wdev->hw_caps.size_inp_ch_buf,
   200		     "%s: request exceed WFx capability: %zu > %d\n", __func__,
   201		     len, wdev->hw_caps.size_inp_ch_buf);
 > 202		cpu_to_le16s(((struct hif_msg *)data)->len);
   203		len = wdev->hwbus_ops->align_size(wdev->hwbus_priv, len);
   204		ret = wfx_data_write(wdev, data, len);
   205		if (ret)
   206			goto end;
   207	
   208		wdev->hif.tx_buffers_used++;
   209		_trace_hif_send(hif, wdev->hif.tx_buffers_used);
   210	end:
   211		if (is_encrypted)
   212			kfree(data);
   213	}
   214	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (53964 bytes)

Powered by blists - more mailing lists