lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 11 May 2020 15:36:36 -0700
From:   Jakub Kicinski <>
To:     Edward Cree <>
Cc:     <>, <>,
Subject: Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type

On Mon, 11 May 2020 13:28:40 +0100 Edward Cree wrote:
> From: Tom Zhao <>
> Various MCDI functions (especially in filter handling) need to check the
>  datapath caps, but those live in nic_data (since they don't exist on
>  Siena).  Decouple from ef10-specific data structures by adding check_caps
>  to the nic_type, to allow using these functions from non-ef10 drivers.
> Also add a convenience macro efx_has_cap() to reduce the amount of
>  boilerplate involved in calling it.
> Signed-off-by: Edward Cree <>

Commit 66119f0b0358 ("sfc: make capability checking a nic_type function")
	author Signed-off-by missing
	author email:
	committer email:
	Signed-off-by: Edward Cree <>

Errors in tree with Signed-off-by, please fix!

Also with W=1:

 ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol 'siena_check_caps' was not declared. Should it be static?
 ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype for ‘siena_check_caps’ [-Wmissing-prototypes]
   951 | unsigned int siena_check_caps(const struct efx_nic *efx,
       |              ^~~~~~~~~~~~~~~~

Powered by blists - more mailing lists