netdev - Re: [PATCH net-next 2/8] sfc: make capability checking a nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200511153636.0f9cd385@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 May 2020 15:36:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type
 function

On Mon, 11 May 2020 13:28:40 +0100 Edward Cree wrote:
> From: Tom Zhao <tzhao@...arflare.com>
> 
> Various MCDI functions (especially in filter handling) need to check the
>  datapath caps, but those live in nic_data (since they don't exist on
>  Siena).  Decouple from ef10-specific data structures by adding check_caps
>  to the nic_type, to allow using these functions from non-ef10 drivers.
> 
> Also add a convenience macro efx_has_cap() to reduce the amount of
>  boilerplate involved in calling it.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Commit 66119f0b0358 ("sfc: make capability checking a nic_type function")
	author Signed-off-by missing
	author email:    tzhao@...arflare.com
	committer email: kuba@...nel.org
	Signed-off-by: Edward Cree <ecree@...arflare.com>

Errors in tree with Signed-off-by, please fix!

Also with W=1:

 ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol 'siena_check_caps' was not declared. Should it be static?
1a3,5
 ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype for â€˜siena_check_capsâ€™ [-Wmissing-prototypes]
   951 | unsigned int siena_check_caps(const struct efx_nic *efx,
       |              ^~~~~~~~~~~~~~~~