lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 12 May 2020 09:56:47 -0700
From:   Brian Norris <>
To:     Navid Emamdoost <>
Cc:,, Kangjie Lu <>,
        QCA ath9k Development <>,
        Kalle Valo <>,
        "David S. Miller" <>,
        linux-wireless <>,
        "<>" <>,
        Linux Kernel <>
Subject: Re: [PATCH] ath9k: release allocated buffer if timed out

On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost
<> wrote:
> In ath9k_wmi_cmd, the allocated network buffer needs to be released
> if timeout happens. Otherwise memory will be leaked.
> Signed-off-by: Navid Emamdoost <>

I wonder, did you actually test your patches? I ask, because it seems
that all your patches are of the same mechanical variety (produced by
some sort of research project?), and if I look around a bit, I see
several mistakes and regressions noted on your other patches. And
recently, I see someone reporting a 5.4 kernel regression, which looks
a lot like it was caused by this patch:

I'll propose a revert, if there's no evidence this was actually tested
or otherwise confirmed to fix a real bug.


Powered by blists - more mailing lists