netdev - Re: [PATCH bpf-next v2] samples/bpf: xdp_redirect_cpu: set MAX_CPUS according to NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae2f2aab-5099-0113-6ff1-fe759f8456b0@fb.com>
Date:   Tue, 12 May 2020 10:03:06 -0700
From:   Yonghong Song <yhs@...com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
CC:     <ast@...nel.org>, <davem@...emloft.net>, <brouer@...hat.com>,
        <daniel@...earbox.net>, <lorenzo.bianconi@...hat.com>
Subject: Re: [PATCH bpf-next v2] samples/bpf: xdp_redirect_cpu: set MAX_CPUS
 according to NR_CPUS



On 5/12/20 9:30 AM, Lorenzo Bianconi wrote:
> xdp_redirect_cpu is currently failing in bpf_prog_load_xattr()
> allocating cpu_map map if CONFIG_NR_CPUS is less than 64 since
> cpu_map_alloc() requires max_entries to be less than NR_CPUS.
> Set cpu_map max_entries according to NR_CPUS in xdp_redirect_cpu_kern.c
> and get currently running cpus in xdp_redirect_cpu_user.c
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Acked-by: Yonghong Song <yhs@...com>