[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEf4BzbE3UYw_rKAGNW9HQ5AVeebt=PDuRnEiijrwaKxNsdiYg@mail.gmail.com>
Date: Tue, 12 May 2020 15:13:18 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Yauheni Kaliuta <yauheni.kaliuta@...hat.com>
Cc: Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
Networking <netdev@...r.kernel.org>,
Alexei Starovoitov <ast@...com>,
Daniel Borkmann <daniel@...earbox.net>,
Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 5/7] selftests/bpf: replace test_progs and
test_maps w/ general rule
On Tue, May 12, 2020 at 1:16 PM Yauheni Kaliuta
<yauheni.kaliuta@...hat.com> wrote:
>
> Hi, Andrii!
>
> The patch blanks TEST_GEN_FILES which was used by install target
> (lib.mk) to install test progs. How is it supposed to work?
>
I actually never used install for selftests, just make and then run
individual test binaries, which explains why this doesn't work :)
> That fixes it for me btw:
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 8f25966b500b..1f878dcd2bf6 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -265,6 +265,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS)
> TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h, \
> $$(filter-out $(SKEL_BLACKLIST), \
> $$(TRUNNER_BPF_SRCS)))
> +TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS)
Yeah, this makes sense, these files will be copied over along the
compiled test_xxx binaries. Do you mind submitting a patch?
[...]
Powered by blists - more mailing lists