netdev - Re: [PATCH v4 bpf-next 5/7] selftests/bpf: replace test_progs and test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xunyimh0ppdh.fsf@redhat.com>
Date:   Wed, 13 May 2020 04:58:34 +0300
From:   Yauheni Kaliuta <yauheni.kaliuta@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 5/7] selftests/bpf: replace test_progs and test_maps w/ general rule

Hi, Andrii!

>>>>> On Tue, 12 May 2020 15:13:18 -0700, Andrii Nakryiko  wrote:

 > On Tue, May 12, 2020 at 1:16 PM Yauheni Kaliuta
 > <yauheni.kaliuta@...hat.com> wrote:
 >> 
 >> Hi, Andrii!
 >> 
 >> The patch blanks TEST_GEN_FILES which was used by install target
 >> (lib.mk) to install test progs. How is it supposed to work?
 >> 

 > I actually never used install for selftests, just make and
 > then run individual test binaries, which explains why this
 > doesn't work :)

Ok :)  Thanks for the clarification.

 >> That fixes it for me btw:
 >> 
 >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
 >> index 8f25966b500b..1f878dcd2bf6 100644
 >> --- a/tools/testing/selftests/bpf/Makefile
 >> +++ b/tools/testing/selftests/bpf/Makefile
 >> @@ -265,6 +265,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS)
 >> TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h,      \
 >> $$(filter-out $(SKEL_BLACKLIST),       \
 >> $$(TRUNNER_BPF_SRCS)))
 >> +TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS)

 > Yeah, this makes sense, these files will be copied over along
 > the compiled test_xxx binaries. Do you mind submitting a
 > patch?

No, sure, I'll do.


-- 
WBR,
Yauheni Kaliuta