netdev - Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <25511589354341@mail.yandex-team.ru>
Date:   Wed, 13 May 2020 10:27:42 +0300
From:   Дмитрий Якунин 
        <zeil@...dex-team.ru>
To:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>
Subject: Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions



13.05.2020, 05:03, "David Ahern" <dsahern@...il.com>:
> On 5/9/20 10:52 AM, Dmitry Yakunin wrote:
>>  This patch prepares infrastructure for matching sockets by cgroups.
>>  Two helper functions are added for transformation between cgroup v2 ID
>>  and pathname. Cgroup v2 cache is implemented as hash table indexed by ID.
>>  This cache is needed for faster lookups of socket cgroup.
>>
>>  v2:
>>    - style fixes (David Ahern)
>
> you missed my other comment about this set. Running this new command on
> a kernel without support should give the user a better error message
> than a string of Invalid arguments:
>
> $ uname -r
> 5.3.0-51-generic
>
> $ ss -a cgroup /sys/fs/cgroup/unified
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument

No, i didn't miss your comment. This patchset was extended with the third patch which includes bytecode filter checking.