netdev - Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42814b4f-dc95-d246-47a4-2b8c46dd607e@gmail.com>
Date:   Tue, 12 May 2020 20:03:25 -0600
From:   David Ahern <dsahern@...il.com>
To:     Dmitry Yakunin <zeil@...dex-team.ru>, netdev@...r.kernel.org
Cc:     cgroups@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and
 helper functions

On 5/9/20 10:52 AM, Dmitry Yakunin wrote:
> This patch prepares infrastructure for matching sockets by cgroups.
> Two helper functions are added for transformation between cgroup v2 ID
> and pathname. Cgroup v2 cache is implemented as hash table indexed by ID.
> This cache is needed for faster lookups of socket cgroup.
> 
> v2:
>   - style fixes (David Ahern)
> 

you missed my other comment about this set. Running this new command on
a kernel without support should give the user a better error message
than a string of Invalid arguments:

$ uname -r
5.3.0-51-generic

$ ss -a cgroup /sys/fs/cgroup/unified
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument