lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 13 May 2020 15:57:58 -0400
From:   "John W. Linville" <linville@...driver.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, Konstantin Kharlamov <hi-angel@...dex.ru>
Subject: Re: [PATCH ethtool] features: accept long legacy flag names when
 setting features

On Mon, Apr 13, 2020 at 11:21:20PM +0200, Michal Kubecek wrote:
> The legacy feature flags have long names (e.g. "generic-receive-offload")
> and short names (e.g. "gro"). While "ethtool -k" shows only long names,
> "ethtool -K" accepts only short names. This is a bit confusing as users
> have to resort to documentation to see what flag name to use; in
> particular, if a legacy flag corresponds to only one actual kernel feature,
> "ethtool -k" shows the output in the same form as if long flag name were
> a kernel feature name but this name cannot be used to set the flag/feature.
> 
> Accept both short and long legacy flag names in "ethool -K".
> 
> Reported-by: Konstantin Kharlamov <hi-angel@...dex.ru>
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Thanks (belatedly) -- queued for next release!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.

Powered by blists - more mailing lists