lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 13 May 2020 15:57:34 -0400
From:   "John W. Linville" <linville@...driver.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, mkubecek@...e.cz, davem@...emloft.net,
        andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH] ethtool.c: Report transceiver correctly

On Fri, Apr 03, 2020 at 05:21:35PM -0700, Florian Fainelli wrote:
> After the transition to the extended link settings ioctl API, the
> kernel, up until commit 9b3004953503462a4fab31b85e44ae446d48f0bd
> ("ethtool: drop get_settings and set_settings callbacks") would support
> the legacy link settings operation and report the transceiver type.
> After this commit, we lost that information although the Linux PHY
> library populates it correctly even with get_link_ksettings() method.
> 
> Ensure that we report the transceiver type correctly for such cases.
> 
> Fixes: 33133abf3b77 ("ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Thanks (belatedly) -- queued for next release!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.

Powered by blists - more mailing lists