netdev - Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <832dc9d7-2a38-9728-a845-2f7f7e34bb74@fb.com>
Date:   Tue, 12 May 2020 20:19:57 -0700
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andriin@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>
CC:     <andrii.nakryiko@...il.com>, <kernel-team@...com>
Subject: Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array
 map



On 5/12/20 4:59 PM, Andrii Nakryiko wrote:
> mmap() subsystem allows user-space application to memory-map region with
> initial page offset. This wasn't taken into account in initial implementation
> of BPF array memory-mapping. This would result in wrong pages, not taking into
> account requested page shift, being memory-mmaped into user-space. This patch
> fixes this gap and adds a test for such scenario.
> 
> Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
> Signed-off-by: Andrii Nakryiko <andriin@...com>
Acked-by: Yonghong Song <yhs@...com>