netdev - Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+iGHrCmWK_9hFF5N6eVF_ASD6dSoLykDRXJRF5z9fi4g@mail.gmail.com>
Date:   Thu, 14 May 2020 12:42:43 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map

On Tue, May 12, 2020 at 8:21 PM Yonghong Song <yhs@...com> wrote:
>
>
>
> On 5/12/20 4:59 PM, Andrii Nakryiko wrote:
> > mmap() subsystem allows user-space application to memory-map region with
> > initial page offset. This wasn't taken into account in initial implementation
> > of BPF array memory-mapping. This would result in wrong pages, not taking into
> > account requested page shift, being memory-mmaped into user-space. This patch
> > fixes this gap and adds a test for such scenario.
> >
> > Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> Acked-by: Yonghong Song <yhs@...com>

Applied. Thanks