lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 May 2020 19:20:32 +0200 From: Bartosz Golaszewski <brgl@...ev.pl> To: Florian Fainelli <f.fainelli@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Bartosz Golaszewski <bgolaszewski@...libre.com> Subject: Re: [PATCH] net: phy: mdio-moxart: remove unneeded include czw., 14 maj 2020 o 19:13 Florian Fainelli <f.fainelli@...il.com> napisaĆ(a): > > > > On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@...libre.com> > > > > mdio-moxart doesn't use regulators in the driver code. We can remove > > the regulator include. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com> > > Reviewed-by: Florian Fainelli <f.fainelli@...il.com> > -- > Florian Hi Andrew, Florian, I noticed this by accident when I was looking at the PHY drivers to see how they handle regulators supplying PHYs. In the case of the MediaTek Pumpkin board I'm working on - the PHY is a Realtek RTL8201F and it's supplied by a regulator that's enabled on boot by the relevant PMIC driver. I'd like to model it in the device-tree but I'm not sure what the correct approach is. Some ethernet drivers have a phy-supply property but it looks wrong to me - IMO this should be handled at the PHY driver level. Is it fine if I add a probe() callback to the realtek driver and retrieve the "phy-supply" there? Bart
Powered by blists - more mailing lists