netdev - Re: [PATCH net-next 0/4] Implement filter terse dump mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200514102647.5c581b5f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 May 2020 10:26:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, dcaratti@...hat.com,
        marcelo.leitner@...il.com
Subject: Re: [PATCH net-next 0/4] Implement filter terse dump mode support

On Thu, 14 May 2020 14:40:22 +0300 Vlad Buslov wrote:
> Implement support for terse dump mode which provides only essential
> classifier/action info (handle, stats, cookie, etc.). Use new
> TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
> kernel.

Looks reasonable:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Apart from the change in NLA_BITFIELD policy build bot already pointed
out there is also an unnecessary new line after a function in patch 2.