netdev - Re: [PATCH net v2] ipv6: Fix suspicious RCU usage warning in ip6mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 16 May 2020 13:43:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     madhuparnabhowmik10@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        kaber@...sh.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, frextrite@...il.com,
        joel@...lfernandes.org, paulmck@...nel.org, cai@....pw,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH net v2] ipv6: Fix suspicious RCU usage warning in ip6mr

From: madhuparnabhowmik10@...il.com
Date: Sat, 16 May 2020 13:15:15 +0530

> From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> This patch fixes the following warning:
> 
> =============================
> WARNING: suspicious RCU usage
> 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
> -----------------------------
> net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> 
> ipmr_new_table() returns an existing table, but there is no table at
> init. Therefore the condition: either holding rtnl or the list is empty
> is used.
> 
> Fixes: d1db275dd3f6e ("ipv6: ip6mr: support multiple tables")
> Reported-by: kernel test robot <lkp@...el.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>

Applied and queued up for -stable, thanks.