netdev - Re: [PATCH] net/packet: simply allocations in alloc_one_pg_vec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200516.134018.1760282800329273820.davem@davemloft.net>
Date:   Sat, 16 May 2020 13:40:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shakeelb@...gle.com
Cc:     edumazet@...gle.com, willemb@...gle.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/packet: simply allocations in alloc_one_pg_vec_page

From: Shakeel Butt <shakeelb@...gle.com>
Date: Fri, 15 May 2020 19:17:36 -0700

> and thus there is no need to have any fallback after vzalloc.

This statement is false.

The virtual mapping allocation or the page table allocations can fail.

A fallback is therefore indeed necessary.