lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 16 May 2020 15:35:46 -0700
From:   Shakeel Butt <>
To:     David Miller <>
Cc:     Eric Dumazet <>,
        Willem de Bruijn <>,
        Jakub Kicinski <>,
        netdev <>,
        LKML <>
Subject: Re: [PATCH] net/packet: simply allocations in alloc_one_pg_vec_page

On Sat, May 16, 2020 at 1:40 PM David Miller <> wrote:
> From: Shakeel Butt <>
> Date: Fri, 15 May 2020 19:17:36 -0700
> > and thus there is no need to have any fallback after vzalloc.
> This statement is false.
> The virtual mapping allocation or the page table allocations can fail.
> A fallback is therefore indeed necessary.

I am assuming that you at least agree that vzalloc should only be
called for non-zero order allocations. So, my argument is if non-zero
order vzalloc has failed (allocations internal to vzalloc, including
virtual mapping allocation and page table allocations, are order 0 and
use GFP_KERNEL i.e. triggering reclaim and oom-killer) then the next
non-zero order page allocation has very low chance of succeeding.

Powered by blists - more mailing lists