lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 May 2020 23:13:03 +0200 From: Michal Kubecek <mkubecek@...e.cz> To: David Miller <davem@...emloft.net> Cc: kuba@...nel.org, netdev@...r.kernel.org, simon.horman@...ronome.com, kernel-team@...com Subject: Re: [PATCH net-next 0/3] ethtool: set_channels: add a few more checks On Sat, May 16, 2020 at 01:56:58PM -0700, David Miller wrote: > From: Jakub Kicinski <kuba@...nel.org> > Date: Fri, 15 May 2020 12:48:59 -0700 > > > There seems to be a few more things we can check in the core before > > we call drivers' ethtool_ops->set_channels. Adding the checks to > > the core simplifies the drivers. This set only includes changes > > to the NFP driver as an example. > > > > There is a small risk in the first patch that someone actually > > purposefully accepts a strange configuration without RX or TX > > channels, but I couldn't find such a driver in the tree. > > Series applied, thanks Jakub. > > And for the record I accept logical 'or' of booleans as valid :-) For the record, my point was that "|=" is a bitwise operator, not logical. Michal
Powered by blists - more mailing lists