netdev - Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200518114401.GB5261@netronome.com>
Date:   Mon, 18 May 2020 13:44:02 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, mkubecek@...e.cz, netdev@...r.kernel.org,
        kernel-team@...com
Subject: Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

On Fri, May 15, 2020 at 12:49:01PM -0700, Jakub Kicinski wrote:
> Core will now perform this check.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index a5aa3219d112..6eb9fb9a1814 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -1438,8 +1438,7 @@ static int nfp_net_set_channels(struct net_device *netdev,
>  	unsigned int total_rx, total_tx;
>  
>  	/* Reject unsupported */
> -	if (!channel->combined_count ||
> -	    channel->other_count != NFP_NET_NON_Q_VECTORS ||
> +	if (channel->other_count != NFP_NET_NON_Q_VECTORS ||
>  	    (channel->rx_count && channel->tx_count))
>  		return -EINVAL;
>  
> -- 
> 2.25.4
>