lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 17 May 2020 12:34:37 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH v2] net: revert "net: get rid of an signed integer
 overflow in ip_idents_reserve()"

From: Shaokun Zhang <>
Date: Sat, 16 May 2020 11:46:49 +0800

> From: Yuqi Jin <>
> Commit adb03115f459 ("net: get rid of an signed integer overflow in ip_idents_reserve()")
> used atomic_cmpxchg to replace "atomic_add_return" inside the function
> "ip_idents_reserve". The reason was to avoid UBSAN warning.
> However, this change has caused performance degrade and in GCC-8,
> fno-strict-overflow is now mapped to -fwrapv -fwrapv-pointer
> and signed integer overflow is now undefined by default at all
> optimization levels[1]. Moreover, it was a bug in UBSAN vs -fwrapv
> /-fno-strict-overflow, so Let's revert it safely.
> [1]
> Suggested-by: Peter Zijlstra <>
> Suggested-by: Eric Dumazet <>
> Signed-off-by: Yuqi Jin <>
> Signed-off-by: Shaokun Zhang <>

Applied, thanks.

Powered by blists - more mailing lists