netdev - Re: [Patch net-next v2 1/2] net: partially revert dynamic lockdep key changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <405579c2-24da-d7e6-863f-f8ed58df878f@gmail.com>
Date:   Sun, 17 May 2020 12:35:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     Taehee Yoo <ap420073@...il.com>, Netdev <netdev@...r.kernel.org>,
        syzbot <syzbot+aaa6fa4949cc5d9b7b25@...kaller.appspotmail.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [Patch net-next v2 1/2] net: partially revert dynamic lockdep key
 changes



On 5/17/2020 11:42 AM, Cong Wang wrote:
> On Sat, May 16, 2020 at 9:53 AM Vladimir Oltean <olteanv@...il.com> wrote:
>> Thanks a lot for presenting the options. In general, xmit in DSA is
>> relatively simple and most of the time stateless. My stacked DSA setup
>> appears to work just fine with NETIF_F_LLTX, including the updating of
>> percpu counters. I'm not really sure if there's something in
>> particular to test?
>> Anyway, will you send a patch with NETIF_F_LLTX or should I do it? I
>> can do further testing if necessary.
> 
> If DSA is software based, there is a large chance it can be just
> using NETIF_F_LLTX, like you said.
> 
> Please do send a patch for this NETIF_F_LLTX. Note my patch
> simply reverts to the old code, this issue probably exists before it.

It transmits frames by calling dev_queue_xmit() after having assigned 
skb->dev to be pointing to the master network device, very much like 
what VLAN devices do for instance, so I believe setting NETIF_F_LLTX is 
fine here.
--
Florian