netdev - Re: [PATCH iproute2-next] tc: mqprio: reject queues count/offset pair count higher than num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <231c5b50-3709-5a2e-ce20-5a90a3c035be@gmail.com>
Date:   Mon, 18 May 2020 08:59:42 -0600
From:   David Ahern <dsahern@...il.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, kiran.patil@...el.com
Subject: Re: [PATCH iproute2-next] tc: mqprio: reject queues count/offset pair
 count higher than num_tc

On 5/13/20 1:47 PM, Maciej Fijalkowski wrote:
> Provide a sanity check that will make sure whether queues count/offset
> pair count will not exceed the actual number of TCs being created.
> 
> Example command that is invalid because there are 4 count/offset pairs
> whereas num_tc is only 2.
> 
>  # tc qdisc add dev enp96s0f0 root mqprio num_tc 2 map 0 0 0 0 1 1 1 1
> queues 4@0 4@4 4@8 4@12 hw 1 mode channel
> 
> Store the parsed count/offset pair count onto a dedicated variable that
> will be compared against opt.num_tc after all of the command line
> arguments were parsed. Bail out if this count is higher than opt.num_tc
> and let user know about it.
> 
> Drivers were swallowing such commands as they were iterating over
> count/offset pairs where num_tc was used as a delimiter, so this is not
> a big deal, but better catch such misconfiguration at the command line
> argument parsing level.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  tc/q_mqprio.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
\

applied to iproute2-next. Thanks,