netdev - Re: [PATCH net-next] net: ipa: Remove ipa_endpoint_stop{,_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdb0b789-bee0-e3a1-546f-24ff94da2dd2@ieee.org>
Date:   Mon, 18 May 2020 10:00:29 -0500
From:   Alex Elder <elder@...e.org>
To:     Jakub Kicinski <kuba@...nel.org>,
        Nathan Chancellor <natechancellor@...il.com>
Cc:     Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipa: Remove ipa_endpoint_stop{,_rx_dma}
 again

On 5/9/20 12:52 AM, Jakub Kicinski wrote:
> On Fri,  8 May 2020 12:41:33 -0700 Nathan Chancellor wrote:
>> When building arm64 allyesconfig:
>>
>> drivers/net/ipa/ipa_endpoint.c: In function 'ipa_endpoint_stop_rx_dma':
>> drivers/net/ipa/ipa_endpoint.c:1274:13: error: 'IPA_ENDPOINT_STOP_RX_SIZE' undeclared (first use in this function)
>> drivers/net/ipa/ipa_endpoint.c:1274:13: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ipa/ipa_endpoint.c:1289:2: error: implicit declaration of function 'ipa_cmd_dma_task_32b_addr_add' [-Werror=implicit-function-declaration]
>> drivers/net/ipa/ipa_endpoint.c:1291:45: error: 'ENDPOINT_STOP_DMA_TIMEOUT' undeclared (first use in this function)
>> drivers/net/ipa/ipa_endpoint.c: In function 'ipa_endpoint_stop':
>> drivers/net/ipa/ipa_endpoint.c:1309:16: error: 'IPA_ENDPOINT_STOP_RX_RETRIES' undeclared (first use in this function)
>>
>> These functions were removed in a series, merged in as
>> commit 33395f4a5c1b ("Merge branch 'net-ipa-kill-endpoint-stop-workaround'").
>>
>> Remove them again so that the build works properly.
>>
>> Fixes: 3793faad7b5b ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
>> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> 
> Applied, thank you!

First, I want to apologize for not responding to this earlier.  There
are some problems with my mail filters and am only now starting to go
through some of these messages...

Thank you Nathan for the fix and Arnd for the review, and Jakub for
merging it.

> I think I already said this, but would be great if IPA built on x86
> with COMPILE_TEST..

Yes I intend to add this but it was not as simple as I had hoped
and other things have had priority; sorry about that.  Soon.

					-Alex