netdev - Re: [PATCH net] __netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22579c6e-76e2-51f3-5911-819784cd30cf@gmail.com>
Date:   Mon, 18 May 2020 08:59:56 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Boris Sukholitko <boris.sukholitko@...adcom.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] __netif_receive_skb_core: pass skb by reference



On 5/18/20 2:01 AM, Boris Sukholitko wrote:
> __netif_receive_skb_core may change the skb pointer passed into it (e.g.
> in rx_handler). The original skb may be freed as a result of this
> operation.
> 
> The callers of __netif_receive_skb_core may further process original skb
> by using pt_prev pointer returned by __netif_receive_skb_core thus
> leading to unpleasant effects.
> 
> The solution is to pass skb by reference into __netif_receive_skb_core.
> 
> Signed-off-by: Boris Sukholitko <boris.sukholitko@...adcom.com>

Please provide a Fixes: tag for such a scary patch.

Thanks.