netdev - Re: [PATCH V6 18/20] net: ks8851: Implement Parallel bus operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200518093309.5550c399@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 18 May 2020 09:33:09 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Lukas Wunner <lukas@...ner.de>, Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH V6 18/20] net: ks8851: Implement Parallel bus operations

On Sun, 17 May 2020 02:33:52 +0200 Marek Vasut wrote:
> Implement accessors for KS8851-16MLL/MLLI/MLLU parallel bus variant of
> the KS8851. This is based off the ks8851_mll.c , which is a driver for
> exactly the same hardware, however the ks8851.c code is much higher
> quality. Hence, this patch pulls out the relevant information from the
> ks8851_mll.c on how to access the bus, but uses the common ks8851.c
> code. To make this patch reviewable, instead of rewriting ks8851_mll.c,
> ks8851_mll.c is removed in a separate subsequent patch.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Lukas Wunner <lukas@...ner.de>
> Cc: Petr Stetiar <ynezz@...e.cz>
> Cc: YueHaibing <yuehaibing@...wei.com>

Please test build with W=1

drivers/net/ethernet/micrel/ks8851_par.c:64:13: warning: context imbalance in 'ks8851_lock_par' - wrong count at exit
drivers/net/ethernet/micrel/ks8851_par.c:78:13: warning: context imbalance in 'ks8851_unlock_par' - unexpected unlock