lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 May 2020 16:03:48 +0200 From: Andrew Lunn <andrew@...n.ch> To: Oleksij Rempel <o.rempel@...gutronix.de> Cc: "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>, Jonathan Corbet <corbet@....net>, Michal Kubecek <mkubecek@...e.cz>, David Jander <david@...tonic.nl>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>, mkl@...gutronix.de, Marek Vasut <marex@...x.de>, Christian Herber <christian.herber@....com> Subject: Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) > --- a/net/ethtool/common.c > +++ b/net/ethtool/common.c > @@ -310,6 +310,16 @@ int __ethtool_get_link(struct net_device *dev) > return netif_running(dev) && dev->ethtool_ops->get_link(dev); > } > > +int __ethtool_get_sqi(struct net_device *dev) > +{ > + struct phy_device *phydev = dev->phydev; > + > + if (!phydev->drv->get_sqi) > + return -EOPNOTSUPP; > + > + return phydev->drv->get_sqi(phydev); > +} > + You are only providing access via netlink ethtool? There is no ioctl method to get this. If so, i wonder if common.c is the correct place for this, or if it should be moved into linkstate.c. You can then drop the __. Michal? Andrew
Powered by blists - more mailing lists