netdev - Re: [PATCH net-next 3/3] selftests: net: Add port split test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 May 2020 21:33:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, danieller@...lanox.com, mlxsw@...lanox.com,
        michael.chan@...adcom.com, jeffrey.t.kirsher@...el.com,
        saeedm@...lanox.com, leon@...nel.org, snelson@...sando.io,
        drivers@...sando.io, vivien.didelot@...il.com,
        f.fainelli@...il.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 3/3] selftests: net: Add port split test

> It's basically the number of lanes

Then why not call it lanes? It makes it clearer how this maps to the
hardware?

> > Is it well defined that all splits of the for 2, 4, 8 have to be
> > supported?
> 
> That I don't actually know. It is true for Mellanox and I can only
> assume it holds for other vendors. So far beside mlxsw only nfp
> implemented port_split() callback. I see it has this check:
> 
> ```
>         if (eth_port.is_split || eth_port.port_lanes % count) {
>                 ret = -EINVAL;
>                 goto out;
>         }
> ```
> 
> So it seems to be consistent with mlxsw. Jakub will hopefully chime in
> and keep me honest.
> 
> > Must all 40Gbps ports with a width of 4, be splitable to 2x
> > 20Mps? It seems like some hardware might only allow 4x 10G?
> 
> Possible. There are many vendor-specific quirks in this area, as I'm
> sure you know :)

So this makes me wonder if the API is sufficient. Do we actually want
to enumerate what is possible, rather than leave the user to guess,
trial and error?

> I assume you're asking because you are trying to see if the test is not
> making some vendor-specific assumptions?

Not just the test, but also the API itself. Is the API generic enough?
Should we actually be able to indicate a 40G port cannot be used as 2x
20G? But 4x 10G is O.K?

The PDF you gave a link to actually says nothing about 2x 50G, or 2x
20G. There is a cable which does support 2x 50G. Does the firmware do
any sanity checking and return errors if you ask it to do something
which does not make sense with the cable currently inserted in the
SFP cage?

	Andrew