netdev - Re: add a new ->ndo_tunnel_ctl method to avoid a few set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200519.154537.2177911931662623148.davem@davemloft.net>
Date:   Tue, 19 May 2020 15:45:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hch@....de
Cc:     kuba@...nel.org, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: add a new ->ndo_tunnel_ctl method to avoid a few set_fs calls
 v2

From: Christoph Hellwig <hch@....de>
Date: Tue, 19 May 2020 15:03:10 +0200

> both the ipv4 and ipv6 code have an ioctl each that can be used to create
> a tunnel using code that doesn't live in the core kernel or ipv6 module.
> Currently they call ioctls on the tunnel devices to create these, for
> which the code needs to override the address limit, which is a "feature"
> I plan to get rid of.
> 
> Instead this patchset adds a new ->ndo_tunnel_ctl that can be used for
> the tunnel configuration using struct ip_tunnel_parm.  The method is
> either invoked from a helper that does the uaccess and can be wired up
> as ndo_do_ioctl method, or directly from the magic IPV4/6 ioctls that
> create tunnels with kernel space arguments.
> 
> Changes since v2:
>  - properly propagate errors in ipip6_tunnel_prl_ctl

Looks good, series applied, thanks.