netdev - Re: [PATCH] sctp: Don't add the shutdown timer if its already been added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200519.154805.2002435538113436383.davem@davemloft.net>
Date:   Tue, 19 May 2020 15:48:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nhorman@...driver.com
Cc:     linux-sctp@...r.kernel.org, vyasevich@...il.com,
        jere.leppanen@...ia.com, marcelo.leitner@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] sctp: Don't add the shutdown timer if its already been
 added

From: Neil Horman <nhorman@...driver.com>
Date: Tue, 19 May 2020 16:04:05 -0400

> This BUG halt was reported a while back, but the patch somehow got
> missed:
> 
 ...
> It appears that the side effect that starts the shutdown timer was processed
> multiple times, which can happen as multiple paths can trigger it.  This of
> course leads to the BUG halt in add_timer getting called.
> 
> Fix seems pretty straightforward, just check before the timer is added if its
> already been started.  If it has mod the timer instead to min(current
> expiration, new expiration)
> 
> Its been tested but not confirmed to fix the problem, as the issue has only
> occured in production environments where test kernels are enjoined from being
> installed.  It appears to be a sane fix to me though.  Also, recentely,
> Jere found a reproducer posted on list to confirm that this resolves the
> issues
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied and queued up for -stable, thanks.