netdev - Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200520100839.0630f025@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 20 May 2020 10:08:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bezrukov <dbezrukov@...vell.com>
Subject: Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC
 support

On Wed, 20 May 2020 16:47:25 +0300 Igor Russkikh wrote:
> From: Dmitry Bezrukov <dbezrukov@...vell.com>
> 
> This patch contains the following changes:
> * add cfg->is_ptp (used for PTP enable/disable switch, which
>   is described in more details below);
> * add cfg->tc_mode (A1 supports 2 HW modes only);
> * setup queue to TC mapping based on TC mode on A2;
> * remove hw_tx_tc_mode_get / hw_rx_tc_mode_get hw_ops.
> 
> In the first generation of our hardware (A1), a whole traffic class is
> consumed for PTP handling in FW (FW uses it to send the ptp data and to
> send back timestamps).
> Since this conflicts with QoS (user is unable to use the reserved TC2),
> we suggest using module param to give the user a choice: disabling PTP
> allows using all available TCs.
> 
> Signed-off-by: Dmitry Bezrukov <dbezrukov@...vell.com>
> Co-developed-by: Mark Starovoytov <mstarovoitov@...vell.com>
> Signed-off-by: Mark Starovoytov <mstarovoitov@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>

drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:951:14: warning: no previous prototype for ptp_ring_idx [-Wmissing-prototypes]
 951 | unsigned int ptp_ring_idx(const enum aq_tc_mode tc_mode)
     |              ^~~~~~~~~~~~