netdev - Re: [PATCH net-next 07/12] net: atlantic: QoS implementation: max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200520101135.31aa1a13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 20 May 2020 10:11:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>
Subject: Re: [PATCH net-next 07/12] net: atlantic: QoS implementation:
 max_rate

On Wed, 20 May 2020 16:47:29 +0300 Igor Russkikh wrote:
> From: Mark Starovoytov <mstarovoitov@...vell.com>
> 
> This patch adds initial support for mqprio rate limiters (max_rate only).
> 
> Atlantic HW supports Rate-Shaping for time-sensitive traffic at per
> Traffic Class (TC) granularity.
> Target rate is defined by:
> * nominal link rate (always 10G);
> * rate factor (ratio between nominal rate and max allowed).
> 
> Signed-off-by: Mark Starovoytov <mstarovoitov@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>

drivers/net/ethernet/aquantia/atlantic/aq_main.c: In function aq_ndo_setup_tc:
drivers/net/ethernet/aquantia/atlantic/aq_main.c:369:7: warning: variable has_max_rate set but not used [-Wunused-but-set-variable]
 369 |  bool has_max_rate;
     |       ^~~~~~~~~~~~
drivers/net/ethernet/aquantia/atlantic/aq_main.c:368:7: warning: variable has_min_rate set but not used [-Wunused-but-set-variable]
 368 |  bool has_min_rate;
     |       ^~~~~~~~~~~~

This probably needs to moved to patch 11 where it's used.