netdev - Re: [PATCH bpf-next v4 03/15] xsk: move driver interface to xdp_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNgxH0xLUvm=MPpF-VhoGLPYF2=gJMAw3VkmduO2SJhy=Q@mail.gmail.com>
Date:   Wed, 20 May 2020 19:18:49 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH bpf-next v4 03/15] xsk: move driver interface to xdp_sock_drv.h

On Wed, 20 May 2020 at 18:57, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 20 May 2020 11:47:30 +0200 Björn Töpel wrote:
> > From: Magnus Karlsson <magnus.karlsson@...el.com>
> >
> > Move the AF_XDP zero-copy driver interface to its own include file
> > called xdp_sock_drv.h. This, hopefully, will make it more clear for
> > NIC driver implementors to know what functions to use for zero-copy
> > support.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
>
> With W=1:
>
> net/xdp/xsk_queue.c:67:26: warning: symbol 'xsk_reuseq_prepare' was not declared. Should it be static?
> net/xdp/xsk_queue.c:86:26: warning: symbol 'xsk_reuseq_swap' was not declared. Should it be static?
> net/xdp/xsk_queue.c:108:6: warning: symbol 'xsk_reuseq_free' was not declared. Should it be static?
> net/xdp/xsk_queue.c:67:27: warning: no previous prototype for xsk_reuseq_prepare [-Wmissing-prototypes]
>   67 | struct xdp_umem_fq_reuse *xsk_reuseq_prepare(u32 nentries)
>      |                           ^~~~~~~~~~~~~~~~~~
> net/xdp/xsk_queue.c:86:27: warning: no previous prototype for xsk_reuseq_swap [-Wmissing-prototypes]
>   86 | struct xdp_umem_fq_reuse *xsk_reuseq_swap(struct xdp_umem *umem,
>      |                           ^~~~~~~~~~~~~~~
> net/xdp/xsk_queue.c:108:6: warning: no previous prototype for xsk_reuseq_free [-Wmissing-prototypes]
>  108 | void xsk_reuseq_free(struct xdp_umem_fq_reuse *rq)
>      |      ^~~~~~~~~~~~~~~

Yes, missing include there. After the series these functions are
removed, but still good to get rid of the (bisect) noise.

I'll fix this in a v5. Thanks, Jakub!


Björn