netdev - Re: [PATCH bpf-next v4 07/15] i40e: separate kernel allocated rx_bi rings from AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 May 2020 19:19:22 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH bpf-next v4 07/15] i40e: separate kernel allocated rx_bi
 rings from AF_XDP rings

On Wed, 20 May 2020 at 19:02, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 20 May 2020 11:47:34 +0200 Björn Töpel wrote:
> > From: Björn Töpel <bjorn.topel@...el.com>
> >
> > Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP
> > zero-copy/sk_buff rx_bi rings are now separate. Functions to properly
> > allocate the different rings are added as well.
> >
> > v3->v4: Made i40e_fd_handle_status() static. (kbuild test robot)
> >
> > Cc: intel-wired-lan@...ts.osuosl.org
> > Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
>
> There is a new warning here, at least one. But i40e has so many
> existing warnings with W=1, I can't figure out which one is new :(
>
> You most likely forgot to adjust kdoc somewhere after adding or
> removing a function parameter.

Hmm, yes. A lot of warnings there. I'll see if I can find it. Thanks!